Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: Improve the use of delegate_to #281

Open
wants to merge 1 commit into
base: qa/1.x
Choose a base branch
from
Open

configure: Improve the use of delegate_to #281

wants to merge 1 commit into from

Conversation

mamedin
Copy link
Contributor

@mamedin mamedin commented Feb 14, 2020

When getting the hostname from archivematica_src_configure_ss_url and
archivematica_src_configure_dashboardsettings dictionaries to be used with
the delegate_to keywork, it could fail when delegated host has different IP
address or hostname from ansible host than the one used by the pipeline host.
For instance, it is on a private network or different DNS zone.

Adding the new variables archivematica_src_configure_ss_inventory_hostname
and archivematica_src_configure_atom_inventory_hostname allows to configure
the delegate_to destination with other hostname or IP address.

Connects to #280

configure: Improve the use of delegate_to
86eb535 
When getting the hostname from `archivematica_src_configure_ss_url` and
`archivematica_src_configure_dashboardsettings` dictionaries to be used with
the `delegate_to` keywork, it could fail when delegated host has different IP
address or hostname from ansible host than the one used by the pipeline host.
For instance, it is on a private network or different DNS zone.

Adding the new variables `archivematica_src_configure_ss_inventory_hostname`
and `archivematica_src_configure_atom_inventory_hostname` allows to configure
the `delegate_to` destination with other hostname or IP address.
@mamedin mamedin self-assigned this Feb 14, 2020
@scollazo
Copy link
Contributor

Should we use SS_URL on those cases?

@mamedin
Copy link
Contributor Author

mamedin commented Feb 19, 2020 •
edited
Loading

Should we use SS_URL on those cases?

Do you mean using https://github.com/artefactual-labs/ansible-archivematica-src/blob/stable/1.10.x/tasks/configure.yml#L59 ?

It should be the same than the archivematica_src_configure_ss_url. This url is used by dashboard server with SS API. Imagine that URL has a hostname from a local DNS domain and you are not using the same DNS server than the AM servers in your ansible host. Then you need to use a fake /etc/hosts entry. It could makes sense when you are the only person that deploys/upgrade the system, but could be a problem for the next one that tries to deploy/upgrade it.

Defining these variables will fix that potential (and weird) issue.

@mamedin
Copy link
Contributor Author

mamedin commented Feb 19, 2020

Other potential case: When the remote host needs a ssh proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scollazo scollazo scollazo approved these changes

@amayita amayita Awaiting requested review from amayita

Assignees

@mamedin mamedin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamedin @scollazo